Web UI uses Webdav instead of ajax/* calls #16902
Conversation
|
Wow. Very cool!! |
| * | ||
| * @return {Promise} promise | ||
| */ | ||
| list: function(path, callback, includeParent) { |
There was a problem hiding this comment.
why add a callback when we're already returning a promise?
There was a problem hiding this comment.
Good point. I was more thinking of people not familiar with promises.
Also I'm not sure yet whether I want this "lib" to depend on jquery at all (which provides the promises implementation).
I'll add to my TODO list to reconsider this. Thanks.
|
Awesome! Stuff like this makes me sorry I left my laptop at home. ;-) On June 12, 2015 1:40:52 PM GMT+02:00, Vincent Petry [email protected] wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
|
@rullzer coding on the beach is probably not a good idea anyway, you don't want sand in your laptop. |
|
@PVince81 rebase please Can we do this step by step? As in merge now and fix remaining issues in a followup prs? |
|
Yeah, I'll try to split them to avoid causing regressions. |
I guess there is not need to split the existing pr - just bring this to a working state and merge .... |
|
Working state is a big word. There is still quite some work needed because PROPFIND doesn't return all the information we used to have with the ajax call so there is a high risk of regression. By splitting I could remove the "list" operation and at least merge the simpler ones. I'll see what I can do. |
thx |
I'll move the todos back to the original ticket to be done separately. |
|
@icewind1991 ok I think I'll only use promises, no callbacks. |
I wish we could just use babel and write es6/7, the |
|
Yeah, but we'd need an IE8 shim or something. Maybe one day... Public page now works and also supports rename, delete, move, create folder 😄
Added better error handling and failing promises. |
|
our permissions property already contains M - to tell if a folder/file is mounted |
|
Right, I could use that. But the old web UI had more detailed info about the mount type. |
|
Solved the mount types without extra attributes. |
|
|
@oparoz @rullzer regarding previews: if I remember well there was a decision to simply let them fail with 404 when they don't exist ? Ideally I'd like to get rid of "isPreviewAvailable" now. It makes the logic quite complex. |
|
@PVince81 the OC.Previews namespace sounds like a good approach... makes it also more clean IMO. Just drop the isPreviewAvailable. |
|
Without isPreviewAvailable, we might get a lot of 404 for files that don't have previews. In this case we should look into caching the 404 errors: #17557 |
This makes it possible to also store custom properties passed through the data object like tags or shareOwner.
This prevents double slashes that can mess up path comparisons in some cases.
This used to be done in the ajax download code. Now that single file downloads are going through Webdav, the token handling needs to be done here too.
This will make sure the cached JS gets properly updated. Also, since this is a bigger change it also qualifies for a version increase :-)
LukasReschke
force-pushed
the
jsocclient
branch
from
fd18a38
to
418fefc
Compare
|
This looks strange: |
|
Clock on the Windows vm is out if sync. Unrelated from my pov |
|
@rullzer @nickvergessen @LukasReschke One more review please :) We need to get this in :) |
|
Works 👍 |
Web UI uses Webdav instead of ajax/* calls
|
Great news for a monday morning 😄 |
|
🎉 🚀 💃 🍻 |
|
You rock! |
|
Party time indeed!!! Awesome. |
Fixes #12353
Tests
Operations
Move
Rename
Create file
Create folder
Delete
Download
Other